Skip to content

Conversation

@gavriliumircea
Copy link
Contributor

@gavriliumircea gavriliumircea commented Oct 23, 2025

This pr aims to add support for the sablier contract addresses and releases

Copy link
Contributor Author

gavriliumircea commented Oct 23, 2025

@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 25626e9 to a8f78b2 Compare October 23, 2025 13:47
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch 2 times, most recently from 709dd5a to d96b0ce Compare October 23, 2025 17:35
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch 2 times, most recently from 1ea5e6a to b09c3c3 Compare October 23, 2025 18:08
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from d96b0ce to 11a6779 Compare October 23, 2025 18:09
@gavriliumircea gavriliumircea marked this pull request as ready for review October 24, 2025 12:53
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from b09c3c3 to ac42da8 Compare October 28, 2025 12:30
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from 11a6779 to 9b0aec6 Compare October 28, 2025 12:30
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from ac42da8 to ec09411 Compare October 29, 2025 17:46
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from 9b0aec6 to 9d29d1f Compare October 29, 2025 17:46
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from ec09411 to 0c55f01 Compare October 29, 2025 17:48
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from 9d29d1f to 2617b9a Compare October 29, 2025 17:48
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 0c55f01 to 22fe14b Compare November 3, 2025 08:07
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from 2617b9a to b2806fd Compare November 3, 2025 08:07
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 22fe14b to 72181ed Compare November 4, 2025 13:42
@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from b2806fd to 6b4779b Compare November 4, 2025 13:42
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed here, we should refer to the Solana backend as 'programs'.

Also, we should de-duplicate stuff. The Contract type (which should be called Program) added in src/solana/types.ts duplicates a lot of the logic from Contract type in src/evm.types.ts.

  • Rename to Program
  • Build an abstraction between Contract and Program in src/shared/types.ts

I will wait for the PRs upstream to be fixed before continuing reviewing the stack.

@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from 6b4779b to e979b40 Compare November 5, 2025 12:47
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 72181ed to 875df5b Compare November 5, 2025 12:47
@gavriliumircea
Copy link
Contributor Author

@PaulRBerg the changes have been made.

@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from e979b40 to 8442d26 Compare November 5, 2025 14:58
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 875df5b to 5a58038 Compare November 5, 2025 14:58
@PaulRBerg PaulRBerg force-pushed the 10-20-feat_add_solana_contract_versions branch from 8442d26 to 8451a48 Compare November 5, 2025 16:23
@PaulRBerg PaulRBerg force-pushed the feat/support-solana-releases branch 2 times, most recently from 5fba41c to d0f4dd4 Compare November 5, 2025 16:48
@PaulRBerg PaulRBerg force-pushed the 10-20-feat_add_solana_contract_versions branch from 8451a48 to 76c3a44 Compare November 5, 2025 16:48
@sablier-labs sablier-labs deleted a comment from coderabbitai bot Nov 5, 2025
@sablier-labs sablier-labs deleted a comment from cursor bot Nov 5, 2025
Copy link
Member

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The IDLs have to be moved underneath an idl directory in each release directory.

As explained here.

@PaulRBerg PaulRBerg force-pushed the feat/support-solana-releases branch from d0f4dd4 to 6bf1e23 Compare November 5, 2025 16:55
@coderabbitai
Copy link

coderabbitai bot commented Nov 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/support-solana-releases

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from e77dcef to d6b1ddc Compare November 6, 2025 11:11
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 6bf1e23 to 6a350f6 Compare November 6, 2025 11:11
@gavriliumircea
Copy link
Contributor Author

The IDLs have to be moved underneath an idl directory in each release directory.

As explained #59 (review).

Did it now. Lmk what you think @prb.

@gavriliumircea gavriliumircea force-pushed the 10-20-feat_add_solana_contract_versions branch from d6b1ddc to 06cad12 Compare November 6, 2025 11:30
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 6a350f6 to 07469fa Compare November 6, 2025 11:30
@gavriliumircea gavriliumircea force-pushed the feat/support-solana-releases branch from 07469fa to 2c5f4f8 Compare November 6, 2025 11:56
@gavriliumircea gavriliumircea merged commit fcadaaf into 10-20-feat_add_solana_contract_versions Nov 6, 2025
2 of 3 checks passed
gavriliumircea added a commit that referenced this pull request Nov 6, 2025
This pr replaces #66. This is need because of a merge order mistake that I did.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants