-
Notifications
You must be signed in to change notification settings - Fork 1
feat: support for solana contracts and releases #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for solana contracts and releases #66
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
25626e9 to
a8f78b2
Compare
709dd5a to
d96b0ce
Compare
1ea5e6a to
b09c3c3
Compare
d96b0ce to
11a6779
Compare
b09c3c3 to
ac42da8
Compare
11a6779 to
9b0aec6
Compare
ac42da8 to
ec09411
Compare
9b0aec6 to
9d29d1f
Compare
ec09411 to
0c55f01
Compare
9d29d1f to
2617b9a
Compare
0c55f01 to
22fe14b
Compare
2617b9a to
b2806fd
Compare
22fe14b to
72181ed
Compare
b2806fd to
6b4779b
Compare
PaulRBerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed here, we should refer to the Solana backend as 'programs'.
Also, we should de-duplicate stuff. The Contract type (which should be called Program) added in src/solana/types.ts duplicates a lot of the logic from Contract type in src/evm.types.ts.
- Rename to
Program - Build an abstraction between
ContractandPrograminsrc/shared/types.ts
I will wait for the PRs upstream to be fixed before continuing reviewing the stack.
6b4779b to
e979b40
Compare
72181ed to
875df5b
Compare
|
@PaulRBerg the changes have been made. |
e979b40 to
8442d26
Compare
875df5b to
5a58038
Compare
8442d26 to
8451a48
Compare
5fba41c to
d0f4dd4
Compare
8451a48 to
76c3a44
Compare
PaulRBerg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The IDLs have to be moved underneath an idl directory in each release directory.
As explained here.
d0f4dd4 to
6bf1e23
Compare
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
e77dcef to
d6b1ddc
Compare
6bf1e23 to
6a350f6
Compare
Did it now. Lmk what you think @prb. |
d6b1ddc to
06cad12
Compare
6a350f6 to
07469fa
Compare
07469fa to
2c5f4f8
Compare
fcadaaf
into
10-20-feat_add_solana_contract_versions
This pr replaces #66. This is need because of a merge order mistake that I did.

This pr aims to add support for the sablier contract addresses and releases