feat: add solana chains #60

gavriliumircea · 2025-10-20T15:12:26Z

This pr aims to add support for the Solana chains used inside the Sablier App.

gavriliumircea · 2025-10-20T15:12:41Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

feat: add solana test and extract evm test in separate directory #67 : 2 dependent PRs (#68 , #76 )
feat: support for solana contracts and releases #66
feat: add solana contract versions #61
feat: add solana chains #60 👈 (View in Graphite)
feat: add solana idls #59
refactor: extract evm specific data in separate directory #65
feat: add package.json exports #58
main

This stack of pull requests is managed by Graphite. Learn more about stacking.

src/types.ts

coderabbitai · 2025-10-22T14:30:21Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch 10-20-feat_add_solana_chains

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

PaulRBerg

feedback

src/index.ts

src/solana/chains/data.ts

src/solana/chains/queries.ts

PaulRBerg · 2025-11-05T09:13:48Z

src/solana/types.ts

+  export type ChainCode = "SOL" | "SOLDEV" | "SOLTEST";
+  export type Cluster = "mainnet-beta" | "devnet" | "testnet";


These should be turned into enums defined in a separate enums.ts file, and the type should be defined like this:

export type Cluster = `${enums.Cluster}` | enums.Cluster;

src/solana/types.ts

src/solana/chains/data.ts

gavriliumircea · 2025-11-05T09:21:51Z

@PaulRBerg regarding the code dedup could you please check #68 and leave the comments there for that?

PaulRBerg · 2025-11-05T09:25:20Z

I could but it is more difficult to review like that because I have to look/review each differential change until then - could you please refactor the de-duplication to be made incrementally so I can review them isolated?

This would save time 🙏

Also, it would be a much cleaner diff in the PR history if we merge the de-duplicated version in the PRs when the logic was introduced

gavriliumircea · 2025-11-05T12:52:57Z

@PaulRBerg I applied the changes that you suggested and removed the refactor pr given that now the dedup is being taken care of in each pr.

PaulRBerg · 2025-11-05T16:39:15Z

src/evm/types.ts

@@ -1,15 +1,6 @@
-import type { Chain as ViemChain } from "viem";
+import type { ChainBase } from "@src/shared/types";


Will rename this to ChainCommon to eliminate the possibility of confusion with the Base EVM chain

cursor · 2025-11-05T16:44:24Z

src/solana/chains/data.ts

+  },
+  chainlink: {
+    feed: "99B2bTijsU6f1GCT73HmdR7HCFFjGMBcPZY6jZ96ynrR",
+    program: "HEvSKofvBgfaexv23kMabbYqxasxU3mQ4ibBMEmJWHny",


Bug: Devnet and Mainnet Chainlink Addresses Mismatch

The Chainlink program and feed addresses are identical for both solanaDevnet and solanaMainnetBeta. Blockchain networks typically use different program addresses and price feed accounts for devnet vs mainnet. Both chains are currently using the same addresses (program: "HEvSKofvBgfaexv23kMabbYqxasxU3mQ4ibBMEmJWHny", feed: "99B2bTijsU6f1GCT73HmdR7HCFFjGMBcPZY6jZ96ynrR"), which will cause devnet to incorrectly point to mainnet Chainlink data or vice versa.

Is this OK, @gavriliumircea?

PaulRBerg

PR looking good now for merging

gavriliumircea mentioned this pull request Oct 20, 2025

feat: add package.json exports #58

Merged

This was referenced Oct 20, 2025

feat: add solana idls #59

Open

feat: add solana contract versions #61

Open

gavriliumircea requested a review from a team October 20, 2025 15:14

razgraf approved these changes Oct 20, 2025

View reviewed changes

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from d331a7c to 2992554 Compare October 21, 2025 07:35

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 4d1f3ef to fd255d1 Compare October 21, 2025 07:35

PaulRBerg reviewed Oct 21, 2025

View reviewed changes

src/types.ts Outdated Show resolved Hide resolved

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from 2992554 to e3cb44d Compare October 22, 2025 14:29

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from fd255d1 to 02fe68d Compare October 22, 2025 14:29

gavriliumircea mentioned this pull request Oct 22, 2025

refactor: extract evm specific data in separate directory #65

Merged

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 02fe68d to f92e682 Compare October 22, 2025 14:33

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from e3cb44d to ad91f01 Compare October 22, 2025 14:33

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch 2 times, most recently from c4cfd25 to e77e2c7 Compare October 22, 2025 15:31

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from ad91f01 to f57e65d Compare October 22, 2025 15:35

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from e77e2c7 to b27a204 Compare October 22, 2025 15:35

This was referenced Oct 23, 2025

feat: support for solana contracts and releases #66

Open

feat: add solana test and extract evm test in separate directory #67

Open

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from f57e65d to 2fbe97c Compare October 23, 2025 13:47

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from b27a204 to 32497e7 Compare October 23, 2025 13:47

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from 2fbe97c to f14b382 Compare October 23, 2025 17:35

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 32497e7 to 1f0f226 Compare October 23, 2025 17:35

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from f14b382 to 7970c81 Compare October 23, 2025 18:08

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 1f0f226 to 6877302 Compare October 23, 2025 18:09

gavriliumircea mentioned this pull request Oct 24, 2025

refactor: improve code reusability between vm types #68

Closed

gavriliumircea marked this pull request as ready for review October 24, 2025 12:52

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from 7970c81 to e31ad15 Compare October 28, 2025 12:30

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 6877302 to 74d7ec9 Compare October 28, 2025 12:30

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from e31ad15 to a522645 Compare October 29, 2025 17:46

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 74d7ec9 to a6037ea Compare October 29, 2025 17:46

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from a522645 to 3fe6fab Compare October 29, 2025 17:48

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch 2 times, most recently from 5610408 to 7fc9613 Compare November 3, 2025 08:07

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch 2 times, most recently from 4edaa74 to 406efce Compare November 4, 2025 13:42

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 7fc9613 to 5e59b4c Compare November 4, 2025 13:42

gavriliumircea mentioned this pull request Nov 4, 2025

refactor: make abis map generic #76

Draft

PaulRBerg changed the base branch from 10-20-feat_add_solana_idls to graphite-base/60 November 5, 2025 09:03

PaulRBerg requested changes Nov 5, 2025

View reviewed changes

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from 5e59b4c to d9c0384 Compare November 5, 2025 12:47

gavriliumircea changed the base branch from graphite-base/60 to 10-20-feat_add_solana_idls November 5, 2025 12:47

gavriliumircea force-pushed the 10-20-feat_add_solana_chains branch from d9c0384 to 4918dc8 Compare November 5, 2025 14:58

gavriliumircea force-pushed the 10-20-feat_add_solana_idls branch from a86e8bb to 1e8cbc4 Compare November 5, 2025 14:58

feat: add solana chains

0f06fcc

PaulRBerg force-pushed the 10-20-feat_add_solana_chains branch from 4918dc8 to 0f06fcc Compare November 5, 2025 16:23

PaulRBerg reviewed Nov 5, 2025

View reviewed changes

refactor: namespace Shared types

99a7a70

cursor bot reviewed Nov 5, 2025

View reviewed changes

PaulRBerg approved these changes Nov 5, 2025

View reviewed changes

		export type ChainCode = "SOL" \| "SOLDEV" \| "SOLTEST";
		export type Cluster = "mainnet-beta" \| "devnet" \| "testnet";

		@@ -1,15 +1,6 @@
		import type { Chain as ViemChain } from "viem";
		import type { ChainBase } from "@src/shared/types";

feat: add solana chains #60

Are you sure you want to change the base?

feat: add solana chains #60

Conversation

gavriliumircea commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gavriliumircea commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

coderabbitai bot commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

PaulRBerg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

PaulRBerg Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gavriliumircea commented Nov 5, 2025

Uh oh!

PaulRBerg commented Nov 5, 2025

Uh oh!

gavriliumircea commented Nov 5, 2025

Uh oh!

PaulRBerg Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

cursor bot Nov 5, 2025

Choose a reason for hiding this comment

Bug: Devnet and Mainnet Chainlink Addresses Mismatch

Uh oh!

PaulRBerg Nov 5, 2025

Choose a reason for hiding this comment

Uh oh!

PaulRBerg left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

gavriliumircea commented Oct 20, 2025 •

edited

Loading

gavriliumircea commented Oct 20, 2025 •

edited

Loading

coderabbitai bot commented Oct 22, 2025 •

edited

Loading