apollo_deployments: change row type to string to remove code duplication in infra panel titles

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_dashboard: improve infra panel code gen fn syntax #10126
• apollo_dashboard: update server-side infra panels #10125
• apollo_dashboard: modify infra panel titles #10115
• apollo_dashboard: refactor infra related panels to a separate module #10075
• apollo_dashboard: reorder infra row panels per request types #10074
• apollo_deployments: change row type to string to remove code duplication in infra panel titles #10069 👈 (View in Graphite)
• apollo_dashboard: reorder infra panels and add missing config manager row #10068
• apollo_dashboard: add microseconds units to tokio panels #10064
• apollo_dashboard: format from_X panel titles #10041
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_dashboard/src/dashboard_definitions.rs line 81 at r2 (raw file):

            get_reverts_row(),
            get_storage_row(),
            get_component_infra_row("Batcher", &BATCHER_INFRA_METRICS),

I want this "Infra" suffix.
Do you want to add it to the get_infra_row builder fn?

Code quote:

Batcher

[Itay-Tsabary-Starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)

---

crates/apollo_dashboard/src/dashboard_definitions.rs line 81 at r2 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

I want this "Infra" suffix.
Do you want to add it to the get_infra_row builder fn?

Of course, it is required, eitherwise it overruns the original Batcher row. Had a pr splitting issue, and this accidently got pushed into the next pr. Moved it here.

[matanl-starkware]

@matanl-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 2 of 3 files at r1, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[graphite-app]

Merge activity

• Nov 12, 4:56 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.