Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@graphite-app graphite-app bot changed the base branch from 11-11-apollo_dashboard_refactor_infra_related_panels_to_a_separate_module to graphite-base/10115 November 12, 2025 18:10
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_modify_infra_panel_titles branch from 21cc79f to cc2e66c Compare November 12, 2025 18:18
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from graphite-base/10115 to 11-11-apollo_dashboard_refactor_infra_related_panels_to_a_separate_module November 12, 2025 18:19
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware changed the base branch from 11-11-apollo_dashboard_refactor_infra_related_panels_to_a_separate_module to main-v0.14.1 November 12, 2025 18:47
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_modify_infra_panel_titles branch from cc2e66c to ab2db10 Compare November 12, 2025 18:47
@graphite-app
Copy link

graphite-app bot commented Nov 12, 2025

Merge activity

  • Nov 12, 6:47 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)


crates/apollo_dashboard/src/infra_panels.rs line 132 at r2 (raw file):

            let trimmed = name_with_filter.strip_suffix('}').unwrap_or(&name_with_filter);

            let with_variant =

Generating the correct expression should be a method of LabeledMerticHistogram

Code quote (i):

let with_variant

Code snippet (ii):

pub fn get_name_with_labeled_filter(label: &str) -> String {
    format!(...)
}

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)


crates/apollo_dashboard/src/infra_panels.rs line 132 at r2 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Generating the correct expression should be a method of LabeledMerticHistogram

Agreed; working on that in a different pr stack

Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Nov 13, 2025
Merged via the queue into main-v0.14.1 with commit 2b99045 Nov 13, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants