-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_dashboard: modify infra panel titles #10115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_dashboard: modify infra panel titles #10115
Conversation
21cc79f to
cc2e66c
Compare
cc2e66c to
ab2db10
Compare
Merge activity
|
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)
crates/apollo_dashboard/src/infra_panels.rs line 132 at r2 (raw file):
let trimmed = name_with_filter.strip_suffix('}').unwrap_or(&name_with_filter); let with_variant =
Generating the correct expression should be a method of LabeledMerticHistogram
Code quote (i):
let with_variantCode snippet (ii):
pub fn get_name_with_labeled_filter(label: &str) -> String {
format!(...)
}
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)
crates/apollo_dashboard/src/infra_panels.rs line 132 at r2 (raw file):
Previously, matanl-starkware (Matan Lior) wrote…
Generating the correct expression should be a method of LabeledMerticHistogram
Agreed; working on that in a different pr stack
ab2db10 to
2fc46d5
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

No description provided.