apollo_dashboard: update server-side infra panels

[Itay-Tsabary-Starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[Itay-Tsabary-Starkware]

• apollo_dashboard: remove from_counter and update relevant panels #10172
• apollo_dashboard: improve infra panel code gen fn syntax #10126
• apollo_dashboard: update server-side infra panels #10125 👈 (View in Graphite)
• apollo_dashboard: modify infra panel titles #10115
• apollo_dashboard: refactor infra related panels to a separate module #10075
• apollo_dashboard: reorder infra row panels per request types #10074
• apollo_deployments: change row type to string to remove code duplication in infra panel titles #10069
• apollo_dashboard: reorder infra panels and add missing config manager row #10068
• apollo_dashboard: add microseconds units to tokio panels #10064
• apollo_dashboard: format from_X panel titles #10041
• main-v0.14.1

This stack of pull requests is managed by Graphite. Learn more about stacking.

[matanl-starkware]

@matanl-starkware reviewed 1 of 3 files at r1, 3 of 3 files at r3, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_dashboard/src/infra_panels.rs line 81 at r3 (raw file):

        let received_msgs_panel = Panel::new(
            "Local request receiving rate",
            format!("Increase of received local requests [{INFRA_INCREASE_DURATION}]"),

Consistency with other panels

Suggestion:

({INFRA_INCREASE_DURATION} window)

---

crates/apollo_dashboard/src/infra_panels.rs line 85 at r3 (raw file):

            PanelType::TimeSeries,
        );
        let processed_msgs_panel = Panel::new(

Consider using Panel::ratio_time_series for processed/received

Code quote:

Panel::new

---

crates/apollo_dashboard/src/infra_panels.rs line 112 at r3 (raw file):

            PanelType::TimeSeries,
        );
        let valid_received_msgs_panel = Panel::new(

Consider using Panel::ratio_time_series for valid/total

Code quote:

 Panel::new

---

crates/apollo_dashboard/src/infra_panels.rs line 118 at r3 (raw file):

            PanelType::TimeSeries,
        );
        let processed_msgs_panel = Panel::new(

Consider using Panel::ratio_time_series for processed/valid

Code quote:

Panel::new

[Itay-Tsabary-Starkware]

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @matanl-starkware)

---

crates/apollo_dashboard/src/infra_panels.rs line 81 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consistency with other panels

Done.

---

crates/apollo_dashboard/src/infra_panels.rs line 85 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consider using Panel::ratio_time_series for processed/received

What ratio do you suggest displaying here? I want to show the processing rate.

---

crates/apollo_dashboard/src/infra_panels.rs line 112 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consider using Panel::ratio_time_series for valid/total

I want rate/increase...

---

crates/apollo_dashboard/src/infra_panels.rs line 118 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

Consider using Panel::ratio_time_series for processed/valid

I want rate/increase...

[matanl-starkware]

@matanl-starkware reviewed 1 of 2 files at r4, all commit messages.
Reviewable status: 2 of 3 files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_dashboard/src/infra_panels.rs line 85 at r3 (raw file):

Previously, Itay-Tsabary-Starkware wrote…

What ratio do you suggest displaying here? I want to show the processing rate.

ratio increase(processed)/increase(received)
This is what ratio_time_series gives you
(checked it, and the ratio varies around 100% as I would expect).

[matanl-starkware]

@matanl-starkware reviewed 1 of 2 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Itay-Tsabary-Starkware)

---

crates/apollo_dashboard/src/infra_panels.rs line 85 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

ratio increase(processed)/increase(received)
This is what ratio_time_series gives you
(checked it, and the ratio varies around 100% as I would expect).

Too many panels IMO.
Need to reconsider how to arrange the "Infra" rows.

[Itay-Tsabary-Starkware]

@Itay-Tsabary-Starkware reviewed 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @matanl-starkware)

---

crates/apollo_dashboard/src/infra_panels.rs line 85 at r3 (raw file):

Previously, matanl-starkware (Matan Lior) wrote…

ratio increase(processed)/increase(received)
This is what ratio_time_series gives you
(checked it, and the ratio varies around 100% as I would expect).

I want to show the processing rate.