Skip to content

Conversation

@Itay-Tsabary-Starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from d1d4255 to e4c2ec6 Compare November 11, 2025 11:03
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_reorder_infra_row_panels_per_request_types branch 2 times, most recently from 89419a8 to 10e914e Compare November 11, 2025 12:58
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from e4c2ec6 to 5580fae Compare November 11, 2025 12:58
Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)


crates/apollo_dashboard/src/dashboard.rs line 635 at r1 (raw file):

    let mut panels: Vec<Panel> = Vec::new();
    // Add the general infra panels.
    panels.extend(UnlabeledPanels::from(metrics.get_local_client_metrics()).0);

I hate this syntax.
Classic example of missing Derive::Deref :-)

Code quote:

.0

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from 5580fae to 7cccff6 Compare November 11, 2025 17:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_reorder_infra_row_panels_per_request_types branch from 10e914e to 4cf5ab1 Compare November 11, 2025 17:50
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from 7cccff6 to f8264c7 Compare November 11, 2025 18:01
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_reorder_infra_row_panels_per_request_types branch from 4cf5ab1 to aa0d27a Compare November 11, 2025 18:01
Copy link
Collaborator

@matanl-starkware matanl-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matanl-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from f8264c7 to 8802c8c Compare November 12, 2025 13:52
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_reorder_infra_row_panels_per_request_types branch 2 times, most recently from 1a006d9 to ac03e0f Compare November 12, 2025 16:29
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles branch from 8802c8c to f4d4e3c Compare November 12, 2025 16:29
@graphite-app graphite-app bot changed the base branch from 11-10-apollo_deployments_change_row_type_to_string_to_remove_code_duplication_in_infra_panel_titles to graphite-base/10074 November 12, 2025 16:55
@Itay-Tsabary-Starkware Itay-Tsabary-Starkware force-pushed the 11-11-apollo_dashboard_reorder_infra_row_panels_per_request_types branch from ac03e0f to 65b7936 Compare November 12, 2025 17:17
@graphite-app graphite-app bot changed the base branch from graphite-base/10074 to main-v0.14.1 November 12, 2025 17:18
@graphite-app
Copy link

graphite-app bot commented Nov 12, 2025

Merge activity

  • Nov 12, 5:18 PM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Itay-Tsabary-Starkware reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware added this pull request to the merge queue Nov 12, 2025
Merged via the queue into main-v0.14.1 with commit 770a85c Nov 12, 2025
22 of 30 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants