-
Notifications
You must be signed in to change notification settings - Fork 65
apollo_dashboard: reorder infra row panels per request types #10074
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apollo_dashboard: reorder infra row panels per request types #10074
Conversation
d1d4255 to
e4c2ec6
Compare
89419a8 to
10e914e
Compare
e4c2ec6 to
5580fae
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
crates/apollo_dashboard/src/dashboard.rs line 635 at r1 (raw file):
let mut panels: Vec<Panel> = Vec::new(); // Add the general infra panels. panels.extend(UnlabeledPanels::from(metrics.get_local_client_metrics()).0);
I hate this syntax.
Classic example of missing Derive::Deref :-)
Code quote:
.05580fae to
7cccff6
Compare
10e914e to
4cf5ab1
Compare
7cccff6 to
f8264c7
Compare
4cf5ab1 to
aa0d27a
Compare
matanl-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@matanl-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
f8264c7 to
8802c8c
Compare
1a006d9 to
ac03e0f
Compare
8802c8c to
f4d4e3c
Compare
ac03e0f to
65b7936
Compare
f4d4e3c to
5f57e9f
Compare
Merge activity
|
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Itay-Tsabary-Starkware reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

No description provided.